663c06be00
Apply suggestions from code review
...
Co-authored-by: anatawa12 <anatawa12@icloud.com>
2024-11-20 19:17:25 -05:00
7ccccf5545
fix(backend): allow accessing private IP when testing
2024-11-20 19:17:25 -05:00
f36f4b5398
fix(backend): check target IP before sending HTTP request
2024-11-20 19:17:25 -05:00
cc4e99fdde
fix: Try using `CacheService` to avoid excess db lookups
...
This isn't perfect, theoretically if some massive number of users
blocked the user making this request the set lookup could take a long
amount of time, but eh, it works, and that scenario is highly unlikely.
2024-11-20 19:17:25 -05:00
5764fa55cb
fix: primitives 25-33: proper local instance checks
2024-11-20 19:17:25 -05:00
74565f67f7
fix: primitives 21, 22, and 23: reuse resolver
...
This also increases the default `recursionLimit` for `Resolver`, as it
theoretically will go higher that it previously would and could possibly
fail on non-malicious collection activities.
2024-11-20 19:17:25 -05:00
408e782507
fix: primitive 19 & 20: respect blocks and hide more
...
Ideally, the user property should also be hidden (as leaving it in leaks
information slightly), but given the schema of the note endpoint, I
don't think that would be possible without introducing some kind of
"ghost" user, who is attributed for posts by users who have you blocked.
2024-11-20 19:17:25 -05:00
cbf8cc376e
fix: primitive 18: `ap/get` bypasses access checks
...
One might argue that we could make this one actually preform access
checks against the returned activity object, but I feel like that's a
lot more work than just restricting it to administrators, since, to me
at least, it seems more like a debugging tool than anything else.
2024-11-20 19:17:25 -05:00
c04f344049
fix: primitive 13: check attribution against actor in notes
2024-11-20 19:17:25 -05:00
b9080da75d
fix: code style for primitive 17
2024-11-20 19:17:24 -05:00
4d925fc086
fix: primitive 17: note same-origin identifier validation can be bypassed by wrapping the id in an array
2024-11-20 19:17:24 -05:00
b74e2e9167
fix: primitive 16: improper same-origin validation for user uri and url
2024-11-20 19:17:24 -05:00
ebea1a2962
fix: primitive 15: improper same-origin validation for note uri and url
2024-11-20 19:17:24 -05:00
4c432c07cb
fix: code style for primitive 14
2024-11-20 19:17:24 -05:00
322b3b677f
fix: primitive 14: improper validation of outbox, followers, following & shared inbox collections
2024-11-20 19:17:24 -05:00
1c7e05ce9e
fix: primitive 7 & 12: prevent poll spoofing
2024-11-20 19:17:24 -05:00
9ab25ede28
fix: primitives 9, 10 & 11: http signature validation doesn't enforce required headers or specify auth header name
2024-11-20 19:17:24 -05:00
174dfb83d0
fix: primitive 6: reject anonymous objects that were fetched by their id
2024-11-20 19:17:24 -05:00
ad8e8793c7
fix: primitives 5 & 8: reject activities with non-string identifiers
2024-11-20 19:17:24 -05:00
1e14612f0e
fix: primitive 4: missing same-origin identifier validation of collection-wrapped activities
2024-11-20 19:17:24 -05:00
9090b745e6
fix: primitive 3: validation of non-final url
2024-11-20 19:17:24 -05:00
d883934826
fix: primitive 2: acceptance of cross-origin alternate links
2024-11-20 19:17:23 -05:00
27339e03c2
merge: Bump version ( !756 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/756
2024-11-20 05:22:39 +00:00
680c2a0718
Bump version
2024-11-20 00:09:56 -05:00
f258888408
merge: Prevent DoS from spammed media proxy requests ( !754 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/754
Approved-by: Julia <julia@insertdomain.name>
2024-11-20 04:59:00 +00:00
d150e92f41
prevent DoS from spammed media proxy requests
2024-11-19 23:31:59 -05:00
680e3ac7a3
merge: release 2024.9.1 ( !733 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/733
Approved-by: Marie <github@yuugi.dev>
Approved-by: Julia <julia@insertdomain.name>
2024-11-05 03:59:23 +00:00
002d0def42
comment out sharkey-specific crowdin link
...
we don't have it set up yet ☹
2024-11-04 20:54:48 +00:00
a769423c15
bump version number for release
2024-11-04 18:50:26 +00:00
e783359aca
merge: Revert "Experimental: dont mark backfetched notes as silent" ( !703 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/703
Approved-by: Julia <julia@insertdomain.name>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
Approved-by: Marie <github@yuugi.dev>
2024-11-03 19:39:00 +00:00
fa03c4cebe
merge: Respect user privacy settings in federation endpoints ( resolves #712 ) ( !652 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/652
Closes #712
Approved-by: Marie <github@yuugi.dev>
Approved-by: dakkar <dakkar@thenautilus.net>
2024-11-02 22:02:54 +00:00
ddf572c22f
fix lint errors in FollowingEntityService.ts
2024-11-02 17:43:11 -04:00
872f987845
hide instance following / followers tabs from logged-out users
2024-11-02 17:39:16 -04:00
37fd454f70
factor out shared code
2024-11-02 17:39:16 -04:00
2e6726c81f
update autogen types
2024-11-02 17:39:16 -04:00
3a72bf453a
respect following privacy settings
2024-11-02 17:39:16 -04:00
65d81a4ae2
Revert "fix incorrect populated object in followers endpoint"
...
This reverts commit 7b9473bf4c0b55facede0e1d1e33297d14184110.
2024-11-02 17:39:16 -04:00
8f0df1f01c
check for blocks in following / followers endpoints
2024-11-02 17:39:16 -04:00
c566fa1f36
require auth for followers & following endpoints
2024-11-02 17:39:16 -04:00
1906dbe1dc
merge: Fix frontend TS configs ( !725 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/725
Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Marie <github@yuugi.dev>
2024-11-02 18:00:57 +00:00
b97db55a94
fix eslint in frontend / frontend-embed
2024-11-02 13:00:49 -04:00
56023140cb
merge: add FriendlyCaptcha as a captcha solution ( !723 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/723
Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
2024-11-02 15:46:25 +00:00
4ad816e0df
fix frontend-embed tsconfig includes
2024-11-02 11:43:24 -04:00
5e054d0218
fix frontend tsconfig includes
2024-11-02 11:40:40 -04:00
b8b077cbad
chore: replace recaptcha with frc
2024-11-02 11:02:13 +00:00
d786e96c2b
upd: add FriendlyCaptcha as a captcha solution
...
FriendlyCaptcha is a german captcha solution which is GDPR compliant and has a non-commerical free license
2024-11-02 02:20:35 +01:00
8824422cb5
merge: Add a clear filter option to the search widget if set ( !722 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/722
Closes #786
Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
2024-11-01 18:01:19 +00:00
bcc845cdb1
merge: Allow admins to create users ( resolves #764 ) ( !719 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/719
Closes #764
Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Marie <github@yuugi.dev>
2024-11-01 18:00:33 +00:00
c8357a410b
upd: append ✔ on set filter
2024-11-01 17:45:04 +00:00
8b16b0fce9
merge: Hide Following Feed from guest users/logged out users and also don't show the button for migrated accounts ( !721 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/721
Closes #787
Approved-by: Amber Null <puppygirlhornyposting@gmail.com>
Approved-by: dakkar <dakkar@thenautilus.net>
2024-11-01 17:33:39 +00:00
rectcoordsystem
rectcoordsystem
Julia Johannesen
Laura Hausmann
Hazelnoot
dakkar
Marie