From d451cc092025420ee092a48b4dabe54ad90a73bd Mon Sep 17 00:00:00 2001 From: Jigme Datse Yli-Rasku Date: Wed, 29 May 2024 23:40:08 -0700 Subject: [PATCH] Catch Exception? This should catch the exception... And log based on that (it won't but maybe I can see better where my error is). --- docs/courier-to-mailman3.md | 3 ++- source/courier-to-mailman3.py | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/courier-to-mailman3.md b/docs/courier-to-mailman3.md index edea69e..39f22e3 100644 --- a/docs/courier-to-mailman3.md +++ b/docs/courier-to-mailman3.md @@ -30,4 +30,5 @@ This is our current version trying to communicate between courier and mailman3. * Logging host and port on same line. * OK, parsing port number, and setting default. * Logging error (I hope), when lmtp fails to be created. - * Maybe this is better? \ No newline at end of file + * Maybe this is better? + * Catch exception, log based on that? \ No newline at end of file diff --git a/source/courier-to-mailman3.py b/source/courier-to-mailman3.py index 1f20ae5..ed6892a 100644 --- a/source/courier-to-mailman3.py +++ b/source/courier-to-mailman3.py @@ -65,7 +65,7 @@ try: # 5xx error else: raise -except: +except smtplib.SMTPException as e: logger.error('lmtp error') - #logger.error('lmtp failed errorno: %s, message: %s', e.errno, e.strerror) + logger.error('lmtp failed errorno: %s, message: %s', e.errno, e.strerror) exit(100) \ No newline at end of file