a47590e64c
add shared (cross-resource) rate limit for proxy
2024-11-25 13:03:51 -05:00
b4a278ae54
merge: Comply with type for Packed<'Note'> (fixes aria client compatibility) ( !771 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/771
Approved-by: dakkar <dakkar@thenautilus.net>
2024-11-22 23:57:22 +00:00
a51fef29c0
remove `minInterval` from `FileServerService`
...
when showing a reply, browser will request the replied-to avatar twice
at the same time, and get confused if one of the requests is refused
something similar seems to happen with videos and their previews
2024-11-22 23:25:07 +00:00
8e07eb7f44
remove duplicate `limit`
...
the `users/lists/push` endpoint already has a limit, of 30/hour
2024-11-22 23:14:37 +00:00
caaa78d98d
merge: Add default rate limit ( !768 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/768
Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Tess K <me@thvxl.se>
Approved-by: Marie <github@yuugi.dev>
2024-11-22 23:03:34 +00:00
ebdfb2feb7
Comply with type for Packed<'Note'>
2024-11-22 21:57:04 +01:00
e3b826db5a
add rate limits to all public endpoints
2024-11-22 15:19:24 -05:00
6b54405003
add default / fallback rate limit
2024-11-22 13:53:41 -05:00
6027b516e1
Fix `.punyHost` misuse
2024-11-20 21:24:35 -05:00
36af07abe2
Fix another style error
2024-11-20 20:31:22 -05:00
23c4aa2571
Fix style error
2024-11-20 20:24:59 -05:00
1758f29364
Fix error in test function calls
2024-11-20 20:16:43 -05:00
fa3cf6c299
Fix type error in security fixes
2024-11-20 20:06:46 -05:00
b0834ebf55
prevent DoS from spammed media proxy requests
2024-11-20 19:37:38 -05:00
8e90484b3e
Bump version
2024-11-20 19:21:57 -05:00
776f6fd1f5
fix(backend): allow fetchSummaryFromProxy, trueMail to access local addresses
2024-11-20 19:17:25 -05:00
7b3e3f8e25
fix(backend): add isLocalAddressAllowed option to getAgentByUrl and send (HttpRequestService)
2024-11-20 19:17:25 -05:00
360d71278a
fix(backend): lint and typecheck
2024-11-20 19:17:25 -05:00
663c06be00
Apply suggestions from code review
...
Co-authored-by: anatawa12 <anatawa12@icloud.com>
2024-11-20 19:17:25 -05:00
7ccccf5545
fix(backend): allow accessing private IP when testing
2024-11-20 19:17:25 -05:00
f36f4b5398
fix(backend): check target IP before sending HTTP request
2024-11-20 19:17:25 -05:00
cc4e99fdde
fix: Try using `CacheService` to avoid excess db lookups
...
This isn't perfect, theoretically if some massive number of users
blocked the user making this request the set lookup could take a long
amount of time, but eh, it works, and that scenario is highly unlikely.
2024-11-20 19:17:25 -05:00
5764fa55cb
fix: primitives 25-33: proper local instance checks
2024-11-20 19:17:25 -05:00
74565f67f7
fix: primitives 21, 22, and 23: reuse resolver
...
This also increases the default `recursionLimit` for `Resolver`, as it
theoretically will go higher that it previously would and could possibly
fail on non-malicious collection activities.
2024-11-20 19:17:25 -05:00
408e782507
fix: primitive 19 & 20: respect blocks and hide more
...
Ideally, the user property should also be hidden (as leaving it in leaks
information slightly), but given the schema of the note endpoint, I
don't think that would be possible without introducing some kind of
"ghost" user, who is attributed for posts by users who have you blocked.
2024-11-20 19:17:25 -05:00
cbf8cc376e
fix: primitive 18: `ap/get` bypasses access checks
...
One might argue that we could make this one actually preform access
checks against the returned activity object, but I feel like that's a
lot more work than just restricting it to administrators, since, to me
at least, it seems more like a debugging tool than anything else.
2024-11-20 19:17:25 -05:00
c04f344049
fix: primitive 13: check attribution against actor in notes
2024-11-20 19:17:25 -05:00
b9080da75d
fix: code style for primitive 17
2024-11-20 19:17:24 -05:00
4d925fc086
fix: primitive 17: note same-origin identifier validation can be bypassed by wrapping the id in an array
2024-11-20 19:17:24 -05:00
b74e2e9167
fix: primitive 16: improper same-origin validation for user uri and url
2024-11-20 19:17:24 -05:00
ebea1a2962
fix: primitive 15: improper same-origin validation for note uri and url
2024-11-20 19:17:24 -05:00
4c432c07cb
fix: code style for primitive 14
2024-11-20 19:17:24 -05:00
322b3b677f
fix: primitive 14: improper validation of outbox, followers, following & shared inbox collections
2024-11-20 19:17:24 -05:00
1c7e05ce9e
fix: primitive 7 & 12: prevent poll spoofing
2024-11-20 19:17:24 -05:00
9ab25ede28
fix: primitives 9, 10 & 11: http signature validation doesn't enforce required headers or specify auth header name
2024-11-20 19:17:24 -05:00
174dfb83d0
fix: primitive 6: reject anonymous objects that were fetched by their id
2024-11-20 19:17:24 -05:00
ad8e8793c7
fix: primitives 5 & 8: reject activities with non-string identifiers
2024-11-20 19:17:24 -05:00
1e14612f0e
fix: primitive 4: missing same-origin identifier validation of collection-wrapped activities
2024-11-20 19:17:24 -05:00
9090b745e6
fix: primitive 3: validation of non-final url
2024-11-20 19:17:24 -05:00
d883934826
fix: primitive 2: acceptance of cross-origin alternate links
2024-11-20 19:17:23 -05:00
d150e92f41
prevent DoS from spammed media proxy requests
2024-11-19 23:31:59 -05:00
002d0def42
comment out sharkey-specific crowdin link
...
we don't have it set up yet ☹
2024-11-04 20:54:48 +00:00
a769423c15
bump version number for release
2024-11-04 18:50:26 +00:00
e783359aca
merge: Revert "Experimental: dont mark backfetched notes as silent" ( !703 )
...
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/703
Approved-by: Julia <julia@insertdomain.name>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
Approved-by: Marie <github@yuugi.dev>
2024-11-03 19:39:00 +00:00
ddf572c22f
fix lint errors in FollowingEntityService.ts
2024-11-02 17:43:11 -04:00
872f987845
hide instance following / followers tabs from logged-out users
2024-11-02 17:39:16 -04:00
37fd454f70
factor out shared code
2024-11-02 17:39:16 -04:00
2e6726c81f
update autogen types
2024-11-02 17:39:16 -04:00
3a72bf453a
respect following privacy settings
2024-11-02 17:39:16 -04:00
65d81a4ae2
Revert "fix incorrect populated object in followers endpoint"
...
This reverts commit 7b9473bf4c0b55facede0e1d1e33297d14184110.
2024-11-02 17:39:16 -04:00
Hazelnoot
dakkar
tess
Julia Johannesen
rectcoordsystem
rectcoordsystem
Laura Hausmann