Commit Graph

2665 Commits

Author SHA1 Message Date
dakkar c4e0bea931 don't return early -- should fix #626
I have no clue why I wrote that code 😭
2024-08-19 18:19:38 +01:00
dakkar f5560783ea merge: misskey 2024.7 (!583)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/583

Approved-by: Marie <github@yuugi.dev>
Approved-by: Julia Johannesen <julia@insertdomain.name>
2024-08-18 18:32:27 +00:00
dakkar 77144b058c make the cap of `activeRateLimitRequests` match the rate limit
It's trivial to have more than 128 requests in flight: open a busy
timeline, scroll a bit down, wait for many notes to arrive, scroll to
the top. The frontend will send "subscribe to note" messages for each
new note that it accumulated, all at once. We don't want to shut down
the connection in those common cases!
2024-08-18 17:57:51 +01:00
dakkar caa0fecdc9 relax websocket rate limits
* the frontend opens 2 websockets at startup (I'm not completely clear
  why), and that `minInterval:1sec` was breaking the second connection
* as the comment says, "catching up" generates many noteSubscribe
  messages
2024-08-18 15:23:45 +01:00
Marie 38430f8ef3 merge: fix lints (!594)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/594

Approved-by: Marie <2-Marie@users.noreply.activitypub.software>
Approved-by: Amelia Yukii <amelia.yukii@shourai.de>
2024-08-18 13:11:27 +00:00
dakkar a58df8ac7c Merge branch 'develop' into feature/misskey-2024.07 2024-08-18 13:13:23 +01:00
dakkar d92402554b merge: Rate limiting for websockets (!598)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/598

Approved-by: Marie <2-Marie@users.noreply.activitypub.software>
Approved-by: Amelia Yukii <amelia.yukii@shourai.de>
2024-08-18 12:09:25 +00:00
Julia Johannesen 3dd993a76a
Add IP and user ID to connection close message 2024-08-17 14:27:43 -04:00
Julia Johannesen c5f7dcbb7e
Come up with better limits 2024-08-17 14:17:58 -04:00
Julia Johannesen aff57333d5
Add @types/proxy-addr 2024-08-17 13:12:16 -04:00
Julia Johannesen 9c1c1e9f09
Fix logging stuff 2024-08-17 13:08:46 -04:00
syuilo 76bbc10aa1 fix(backend): 無制限にストリーミングのチャンネルに接続できる問題を修正 2024-08-17 17:54:04 +01:00
Hazel K 5e352033c8 fix error spam from ServerStatsService when running on Windows 2024-08-17 10:00:27 -04:00
Julia Johannesen 6d3f9503ed
Limit number of rate limit requests 2024-08-16 17:13:20 -04:00
dakkar 4cd44130e0 use the correct remote address
we're doing the same thing that Fastify does in the non-streaming
ServerService
2024-08-16 18:00:50 +01:00
かっこかり b9097d968c fix(backend): getApTypeでエラーを投げないように (misskey #14361) 2024-08-16 12:38:18 +01:00
dakkar 311a31da58 rough rate limiting for websockets 2024-08-15 11:35:51 +01:00
dakkar 99a0765eaf Merge branch 'develop' into feature/misskey-2024.07 2024-08-14 11:53:57 +01:00
dakkar 01958da57f merge: fix webfinger for instances without a `/host-meta` (!593)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/593

Approved-by: Amelia Yukii <amelia.yukii@shourai.de>
Approved-by: Marie <marie@kaifa.ch>
2024-08-06 20:49:11 +00:00
dakkar 9672f0b48e fix comparison (thanks linter) 2024-08-06 21:21:38 +01:00
dakkar 03d9288f44 fix spacing (thanks linter) 2024-08-06 21:21:29 +01:00
dakkar f33aedfc9f merge: fix env variable type (!592)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/592

Approved-by: Marie <marie@kaifa.ch>
Approved-by: Tess K <me@thvxl.se>
2024-08-06 19:41:26 +00:00
dakkar 4c409dd6c6 fix comparison (thanks linter) 2024-08-06 19:51:11 +01:00
dakkar e9255d45f8 fix spacing (thanks linter) 2024-08-06 19:23:03 +01:00
dakkar 8d29df64fa fix webfinger for instances without a `/host-meta`
we were inconsistent with the colons, thanks to usedbunny for
noticing!
2024-08-06 19:07:01 +01:00
dakkar 94dceb9e15 Merge branch 'develop' into feature/misskey-2024.07 2024-08-06 17:51:51 +01:00
dakkar 4e7df7a5f2 merge: Remove infinite caches to prevent memory leak (!587)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/587

Closes #600 and #601

Approved-by: Amelia Yukii <amelia.yukii@shourai.de>
Approved-by: Marie <marie@kaifa.ch>
2024-08-06 16:51:18 +00:00
dakkar 790c75b1a3 merge: Add icon for moving files/folders - for !583 (!586)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/586

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: fEmber <acomputerdog@gmail.com>
2024-08-06 16:33:17 +00:00
Hazel K 9930c64f2d Fix timeout comments
Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
2024-08-06 12:13:17 -04:00
Marie d798809875 upd: add back in timestamps on src 2024-08-06 15:54:18 +00:00
Marie 9d4d2a1fad upd: align font with new repo 2024-08-06 15:35:52 +00:00
dakkar 2f97b5976f merge: use `XMLSerializer` for `toMastoApiHtml` - fixes #556 (!591)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/591

Closes #556

Approved-by: Marie <marie@kaifa.ch>
Approved-by: fEmber <acomputerdog@gmail.com>
2024-08-06 14:09:35 +00:00
dakkar f85e8a4278 appease the linter 2024-08-06 11:42:03 +01:00
dakkar 9de422280f merge: feat: implement `attachLdSignatureForRelays` to control signing of Relayed activities (#599) (!579)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/579

Closes #599

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Marie <marie@kaifa.ch>
2024-08-06 10:40:14 +00:00
dakkar d899eb30b1 merge: delete old emoji file when replaced - fixes #608 (!589)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/589

Closes #608

Approved-by: fEmber <acomputerdog@gmail.com>
Approved-by: Marie <marie@kaifa.ch>
2024-08-06 10:39:41 +00:00
dakkar 5c3a4925d6 merge: Improve the check_connect script (!588)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/588

Approved-by: fEmber <acomputerdog@gmail.com>
Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Marie <marie@kaifa.ch>
2024-08-06 10:39:27 +00:00
dakkar 5565985f84 appease the linter 2024-08-06 11:35:03 +01:00
dakkar 8afe46122d fix type for env variable 2024-08-06 11:32:26 +01:00
dakkar cb5de3fbfc fix type for env variable 2024-08-06 11:24:43 +01:00
dakkar 151470d882 make "media silenced" work like "silenced"
that is, silencing `foo.com` also silences `sub.foo.com`
2024-08-06 11:14:24 +01:00
dakkar 02748edd17 remove spurious `.then()` 2024-08-06 11:03:09 +01:00
dakkar 6379deb5a7 fail `AbuseReportService.resolve` harder without remote users
as @fEmber noticed, if `findOneByOrFail` throws, we would have marked
the report as resolved, without logging that

this way, the whole operation fails (the frontend should not send us
ids of users that can't be resolved!)
2024-08-06 11:01:18 +01:00
dakkar 34c1e9ea2b Merge branch 'develop' into feature/misskey-2024.07
fixing conflicts in `package.json`
2024-08-06 10:35:14 +01:00
dakkar 712af44de4 merge: don't send real-time updates of replies to blocked users #457 #573 (!566)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/566

Approved-by: Tess K <me@thvxl.se>
Approved-by: fEmber <acomputerdog@gmail.com>
2024-08-06 09:26:40 +00:00
dakkar 76a966041f merge: Fall back to port 3000 if none is specified (!584)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/584

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: fEmber <acomputerdog@gmail.com>
2024-08-06 09:23:08 +00:00
dakkar b93494d746 merge: make sure that `sensitive` is a boolean - fixes #596 (!590)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/590

Closes #596

Approved-by: fEmber <acomputerdog@gmail.com>
Approved-by: Marie <marie@kaifa.ch>
2024-08-06 09:20:53 +00:00
dakkar 61c13241ba use `XMLSerializer` for `toMastoApiHtml` - fixes #556
the `inline` bit is not pretty, but does the job
2024-08-06 10:13:53 +01:00
4censord 0386e52d6f
Impove the check_connect script 2024-08-06 00:35:35 +02:00
dakkar 58d329e3bd make sure that `sensitive` is a boolean - fixes #596
Some remote instances may send garbage. If the `sensitive` value
passed to `driveService.uploadFromUrl` is not a boolean, eventually
we'll get an exception from the database complaining about that. This
change avoids that problem.
2024-08-05 10:12:27 +01:00
dakkar 1e86cba7dc delete old emoji file when replaced - fixes #608
it's the same code that 5f7fc54ee9 added
to `delete` and `deleteBulk`, with the extra check that we're not
deleting the same file we're setting
2024-08-05 09:27:06 +01:00