Merge pull request #9970 from saschanaz/mkusername-empty

fix(backend/ApPersonService): normalize empty value of `name` into an absent value

packages/backend/src/core/activitypub/models/ApPersonService.ts

@@ -164,6 +164,9 @@ export class ApPersonService implements OnModuleInit {
 				throw new Error('invalid Actor: wrong name');
 			}
 			x.name = truncate(x.name, nameLength);
+		} else if (x.name === '') {
+			// Mastodon emits empty string when the name is not set.
+			x.name = undefined;
 		}
 		if (x.summary) {
 			if (!(typeof x.summary === 'string' && x.summary.length > 0)) {

packages/backend/test/unit/activitypub.ts

@@ -11,8 +11,25 @@ import { GlobalModule } from '@/GlobalModule.js';
 import { CoreModule } from '@/core/CoreModule.js';
 import { FederatedInstanceService } from '@/core/FederatedInstanceService.js';
 import { LoggerService } from '@/core/LoggerService.js';
+import type { IActor } from '@/core/activitypub/type.js';
 import { MockResolver } from '../misc/mock-resolver.js';
 
+const host = 'https://host1.test';
+
+function createRandomActor(): IActor & { id: string } {
+	const preferredUsername = `${rndstr('A-Z', 4)}${rndstr('a-z', 4)}`;
+	const actorId = `${host}/users/${preferredUsername.toLowerCase()}`;
+
+	return {
+		'@context': 'https://www.w3.org/ns/activitystreams',
+		id: actorId,
+		type: 'Person',
+		preferredUsername,
+		inbox: `${actorId}/inbox`,
+		outbox: `${actorId}/outbox`,
+	};
+}
+
 describe('ActivityPub', () => {
 	let noteService: ApNoteService;
 	let personService: ApPersonService;
@@ -36,18 +53,7 @@ describe('ActivityPub', () => {
 	});
 
 	describe('Parse minimum object', () => {
-		const host = 'https://host1.test';
+		const actor = createRandomActor();
-		const preferredUsername = `${rndstr('A-Z', 4)}${rndstr('a-z', 4)}`;
-		const actorId = `${host}/users/${preferredUsername.toLowerCase()}`;
-
-		const actor = {
-			'@context': 'https://www.w3.org/ns/activitystreams',
-			id: actorId,
-			type: 'Person',
-			preferredUsername,
-			inbox: `${actorId}/inbox`,
-			outbox: `${actorId}/outbox`,
-		};
 
 		const post = {
 			'@context': 'https://www.w3.org/ns/activitystreams',
@@ -80,29 +86,31 @@ describe('ActivityPub', () => {
 		});
 	});
 
-	describe('Truncate long name', () => {
+	describe('Name field', () => {
-		const host = 'https://host1.test';
+		test('Truncate long name', async () => {
-		const preferredUsername = `${rndstr('A-Z', 4)}${rndstr('a-z', 4)}`;
+			const actor = {
-		const actorId = `${host}/users/${preferredUsername.toLowerCase()}`;
+				...createRandomActor(),
+				name: rndstr('0-9a-z', 129),
+			};
 
-		const name = rndstr('0-9a-z', 129);
-
-		const actor = {
-			'@context': 'https://www.w3.org/ns/activitystreams',
-			id: actorId,
-			type: 'Person',
-			preferredUsername,
-			name,
-			inbox: `${actorId}/inbox`,
-			outbox: `${actorId}/outbox`,
-		};
-
-		test('Actor', async () => {
 			resolver._register(actor.id, actor);
 
 			const user = await personService.createPerson(actor.id, resolver);
 
-			assert.deepStrictEqual(user.name, actor.name.substr(0, 128));
+			assert.deepStrictEqual(user.name, actor.name.slice(0, 128));
+		});
+
+		test('Normalize empty name', async () => {
+			const actor = {
+				...createRandomActor(),
+				name: '',
+			};
+
+			resolver._register(actor.id, actor);
+
+			const user = await personService.createPerson(actor.id, resolver);
+
+			assert.strictEqual(user.name, null);
 		});
 	});
 });